[GitHub] [cloudstack-primate] ravening commented on a change in pull request #446: Allow creating Compute/Disk offering as Domain admin

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446#discussion_r444242685



##########
File path: src/config/section/offering.js
##########
@@ -27,7 +27,6 @@ export default {
       docHelp: 'adminguide/service_offerings.html#compute-and-disk-service-offerings',
       icon: 'cloud',
       permission: ['listServiceOfferings', 'listDomains'],
-      params: { isrecursive: 'true' },

Review comment:
       `isrecursive=true` has a bug with disk/compute offerings
   
   It wont display the parent offerings in the child domain. This bug has to fixed in cloudstack codebase as well
   
   Lets say I have ROOT -> child -> grandchild domains and if I created offering for "child" domain then I cant view that in "grandchild" domain using isrecursive=true




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org