You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/14 09:53:28 UTC
[GitHub] [rocketmq-client-go] aireet opened a new issue, #973: VerifyIP blocked DNS style
aireet opened a new issue, #973:
URL: https://github.com/apache/rocketmq-client-go/issues/973
The issue tracker is **ONLY** used for the go client (feature request of RocketMQ need to follow [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)). Keep in mind, please check whether there is an existing same report before your raise a new one.
Alternately (especially if your communication is not a bug report), you can send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.
Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as to the following:
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
I deploy rocketmq on k8s, and use coreDNS addr to connect it. then i was blocked by VerifyIP function
- What did you expect to see?
do not intercept connect when the addr not like ipv4 and ipv6
if the addr actually wrong, the tcp connection will failed and it will sign definite error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] aireet commented on issue #973: VerifyIP blocked DNS style
Posted by "aireet (via GitHub)" <gi...@apache.org>.
aireet commented on issue #973:
URL: https://github.com/apache/rocketmq-client-go/issues/973#issuecomment-1441501357
PR https://github.com/apache/rocketmq-client-go/pull/1010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] aireet commented on issue #973: VerifyIP blocked DNS style
Posted by "aireet (via GitHub)" <gi...@apache.org>.
aireet commented on issue #973:
URL: https://github.com/apache/rocketmq-client-go/issues/973#issuecomment-1445412132
https://github.com/apache/rocketmq-client-go/pull/1010 PR 在这里， 顺便改了使用net包校验ipv4,6 url host:port的方式
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] aireet commented on issue #973: VerifyIP blocked DNS style
Posted by "aireet (via GitHub)" <gi...@apache.org>.
aireet commented on issue #973:
URL: https://github.com/apache/rocketmq-client-go/issues/973#issuecomment-1587329596
@francisoliverlee 这个pr有计划merge么，我们确实需要通过coreDNS来访问Namesrv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] francisoliverlee commented on issue #973: VerifyIP blocked DNS style
Posted by "francisoliverlee (via GitHub)" <gi...@apache.org>.
francisoliverlee commented on issue #973:
URL: https://github.com/apache/rocketmq-client-go/issues/973#issuecomment-1439404905
从现在的逻辑看，是需要检查namesrv地址的有效性，
1. ipv4
2. ipv6
3. http://或者https://开头。
这个检查没有覆盖namesrv1.com, namesrv1.com;namesrv2.com这种域名场景， 非常欢迎你提交PR修复它。
VerifyIP()代码：
https://github.com/apache/rocketmq-client-go/blob/26142da1b88ef22ac018138c724f5d4f48059da3/primitive/base.go#L33-L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] aireet commented on issue #973: VerifyIP blocked DNS style
Posted by "aireet (via GitHub)" <gi...@apache.org>.
aireet commented on issue #973:
URL: https://github.com/apache/rocketmq-client-go/issues/973#issuecomment-1441502313
> 从现在的逻辑看，是需要检查namesrv地址的有效性，目前支持以下几种：
>
> 1. ipv4
> 2. ipv6
> 3. [http://或者https://开头。](http://%E6%88%96%E8%80%85https://%E5%BC%80%E5%A4%B4%E3%80%82)
>
> 这个检查没有覆盖namesrv1.com, namesrv1.com;namesrv2.com这种域名场景， 非常欢迎你提交PR修复它。
>
> VerifyIP()代码：
>
> https://github.com/apache/rocketmq-client-go/blob/26142da1b88ef22ac018138c724f5d4f48059da3/primitive/base.go#L33-L86
PR https://github.com/apache/rocketmq-client-go/pull/1010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org