You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/17 05:16:33 UTC
[GitHub] [skywalking] andotorg opened a new issue, #9077: [Feature] endpoint name drop-down box to the limit
andotorg opened a new issue, #9077:
URL: https://github.com/apache/skywalking/issues/9077
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
```
export const Endpoints = {
variable: '$serviceId: ID!, $keyword: String!',
query: getEndpoints: searchEndpoint(serviceId: $serviceId, keyword: $keyword, limit: 100) { key: id label: name },
};
```
Because skywalking has access to many systems and there are many endpoints, it is obviously inappropriate to add the data of the drop-down box to the limit
### Use case
recovery input endpoint name the request path
### Related issues
not
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128482372
What's the point of endpoint name search? There is no reference meaning. I think it is better to replace the input box before 8.6 instead of the drop-down selection box. That's what I mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1129741222
That is your choice. We just as a community, don't accept relative requests anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9077: [Feature] endpoint name drop-down box to the limit
URL: https://github.com/apache/skywalking/issues/9077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128486912
When the user inputs, the server will fuzzy query the latest data return according to the user input, which is the best user experience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128659150
There is no `submitter team` in the ASF.
The committer team is the one is trusted by the PMC(Project Management Committee), who could do routine code review and merging. The PMC is a smaller group of people watching and sheepherders of the project.
This doc would show how a committer gets promoted, https://skywalking.apache.org/docs/main/latest/en/guides/asf/committer/, and here are the current committers and PMC members, https://skywalking.apache.org/team/.
The basic principle is, that you need to begin contributing to the project through pull requests, such as bug fixing, or begin to work on a new feature if you have an idea, the idea gets discussed, and at least one of PMC gets you to support to do.
SkyWalking is a community of volunteers, so, there is no one to assign you anything, you need to find things to do because you feel you want to.
About this feature(endpoint name-based search), the conclusion was made, that unless we have committers to initial a new discussion again, we wouldn't accept it back in the mainstream. This is how a community works, we have 600+ code contributors, and countless users. The decision is the decision, very serious, not be able to change randomly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1129739846
There are no plans to use versions above 9.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128554673
There was a long discussion one year ago, this search is simple but has a super bad performance impact on the trace query. So, the community has decided to remove it.
This is a community, diverse groups of people, make the final decision. If you want your voice to be considered seriously, you need to be a part of the committer team based on your contributions to this community.
A project can't make everyone happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1129468238
I see. Thank you for your answer。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128649246
I hope to submit the corresponding code to contribute to this community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1129497447
Now, we are working on 9.1, the old versions are not our concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128648006
please， How to be part of the submitter team.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1129470171
> skywalking 8.7.0 have a webui bug, submene "xxx.com:8080/trace" refresh page，It will jump to the back-end 404 address <img alt="image" width="597" src="https://user-images.githubusercontent.com/25116294/168937666-820a8e24-d5bb-4240-ae8d-953e30ea4a5d.png">
After my testing of each version, only 8.7 will have this problem, and neither 8.6 nor 8.8 will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128476717
Endpoint search would not pull all data, that is unrealistic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1128483213
I think we can open this question and think about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1129790070
ok, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] andotorg commented on issue #9077: [Feature] endpoint name drop-down box to the limit
Posted by GitBox <gi...@apache.org>.
andotorg commented on issue #9077:
URL: https://github.com/apache/skywalking/issues/9077#issuecomment-1129469855
skywalking 8.7.0 have a webui bug, submene "xxx.com:8080/trace" refresh page，It will jump to the back-end 404 address
<img width="597" alt="image" src="https://user-images.githubusercontent.com/25116294/168937666-820a8e24-d5bb-4240-ae8d-953e30ea4a5d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org