[jira] [Work logged] (TS-4674) Cleanup incorrect assert after TS-4403

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4674?focusedWorklogId=25640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25640 ]

ASF GitHub Bot logged work on TS-4674:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/16 16:17
            Start Date: 18/Jul/16 16:17
    Worklog Time Spent: 10m 
      Work Description: GitHub user jacksontj opened a pull request:

    https://github.com/apache/trafficserver/pull/809

    TS-4674: Remove useless assert statement

    Now that we have clean allocations (instead of clobbering existing things) there is no need to have this assertion. In practice this assertion is actually incorrect, because in the case where we want to extend the lifetime of a stale record (since the response we got was broken) we'll fail this assert.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jacksontj/trafficserver TS-4674

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #809
    
----
commit 44f9dcddab6cfe755e1b6dd87093762c44e7e7b9
Author: Thomas Jackson <ja...@gmail.com>
Date:   2016-07-18T16:13:03Z

    TS-4674: Remove useless assert statement
    
    Now that we have clean allocations (instead of clobbering existing things) there is no need to have this assertion. In practice this assertion is actually incorrect, because in the case where we want to extend the lifetime of a stale record (since the response we got was broken) we'll fail this assert.

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 25640)
            Time Spent: 10m
    Remaining Estimate: 0h

> Cleanup incorrect assert after TS-4403
> --------------------------------------
>
>                 Key: TS-4674
>                 URL: https://issues.apache.org/jira/browse/TS-4674
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HostDB
>            Reporter: Thomas Jackson
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now that we allow for some records to persist in the case of failure, the records in this path are not always in the 0 state--and therefore this assert doesn't work. Regardless this assert is a bit useless since the replacement of multicache with RefCountCache-- as we aren't clobbering memory all over creation-- so the need for these types of asserts is significantly reduced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)