[GitHub] [beam] ahmedabu98 commented on a diff in pull request #28032: Add more batch Storage Write API tests

["ahmedabu98 (via GitHub)" <gi...@apache.org>]

ahmedabu98 commented on code in PR #28032:
URL: https://github.com/apache/beam/pull/28032#discussion_r1296309909


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -1329,8 +1330,12 @@ static class SchemaPojo {
   }
 
   @Test
-  public void testSchemaWriteLoads() throws Exception {
-    assumeTrue(!useStreaming);
+  public void testBatchSchemaWriteLoads() throws Exception {
+    // This test is actually for batch!
+    // We just invert useStreaming because we need it as true to test
+    // STORAGE_API_AT_LEAST_ONCE,
+    assumeTrue(useStreaming);

Review Comment:
   I meant that we're meant to use `!useStreaming` for batch tests, but used `useStreaming` instead. Will update comments to clarify



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org