You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/27 12:23:54 UTC

[GitHub] sijie opened a new pull request #1211: Use the bk OrderedScheduler in dlog

sijie opened a new pull request #1211: Use the bk OrderedScheduler in dlog
URL: https://github.com/apache/bookkeeper/pull/1211
 
 
   Descriptions of the changes in this PR:
   
   Dlog has an implementation of OrderedScheduler inspired of bk `OrderedScheduler`. It would be good to remove duplicated implementation here since dlog is in the same repo as bk.
   
   - removed the dlog version of `OrderedScheduler`
   - make `OrderedScheduler` implement `ScheduledExecutorService` so it can be used by dlog
   - change dlog classes to use bk `OrderedScheduler`.
   
   Master Issue: #1024 
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services