You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by GitBox <gi...@apache.org> on 2018/07/30 19:29:22 UTC

[GitHub] rdelval closed pull request #23: Fix bug. Do not increase current_consecutive_successes if .healthchec…

rdelval closed pull request #23: Fix bug. Do not increase current_consecutive_successes if .healthchec…
URL: https://github.com/apache/aurora/pull/23
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/python/apache/aurora/executor/common/health_checker.py b/src/main/python/apache/aurora/executor/common/health_checker.py
index e9e4129af..4c289344a 100644
--- a/src/main/python/apache/aurora/executor/common/health_checker.py
+++ b/src/main/python/apache/aurora/executor/common/health_checker.py
@@ -160,6 +160,11 @@ def _maybe_update_health_check_count(self, is_healthy, reason):
         self.healthy = False
         self.reason = reason
     else:
+      if self.snoozed:
+        log.debug('Reset consecutive successes counter.')
+        self.current_consecutive_successes = 0
+        return
+
       self.current_consecutive_successes += 1
 
       if not self.running:


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services