You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/01/30 00:29:56 UTC
Review Request 42986: Updated webui to show count for tasks in
`TASK_RUNNING` state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Bugs: MESOS-4562
https://issues.apache.org/jira/browse/MESOS-4562
Repository: mesos
Description
-------
Previously, it was showing the count for tasks in `TASK_STARTING` state.
Diffs
-----
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
Diff: https://reviews.apache.org/r/42986/diff/
Testing
-------
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
Re: Review Request 42986: Fixed webui task counts for
STARTING/RUNNING tasks.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/#review117160
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 31, 2016, 6:41 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42986/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 6:41 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-4562
> https://issues.apache.org/jira/browse/MESOS-4562
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The "Starting" and "Running" counts show the number of tasks in
> "TASK_STARTING" and "TASK_RUNNING" state respectively.
>
>
> Diffs
> -----
>
> src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1
> src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
> src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3
>
> Diff: https://reviews.apache.org/r/42986/diff/
>
>
> Testing
> -------
>
> Launched 100 sleeps tasks and verified the status in webui.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 42986: Fixed webui task counts for
STARTING/RUNNING tasks.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/
-----------------------------------------------------------
(Updated Jan. 31, 2016, 1:41 p.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Changes
-------
Changed "Staged" to "Staging".
Bugs: MESOS-4562
https://issues.apache.org/jira/browse/MESOS-4562
Repository: mesos
Description
-------
The "Starting" and "Running" counts show the number of tasks in
"TASK_STARTING" and "TASK_RUNNING" state respectively.
Diffs (updated)
-----
src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3
Diff: https://reviews.apache.org/r/42986/diff/
Testing
-------
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
Re: Review Request 42986: Fixed webui task counts for
STARTING/RUNNING tasks.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/
-----------------------------------------------------------
(Updated Jan. 31, 2016, 1:37 p.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Changes
-------
Added "Starting" to web-ui task count.
Summary (updated)
-----------------
Fixed webui task counts for STARTING/RUNNING tasks.
Bugs: MESOS-4562
https://issues.apache.org/jira/browse/MESOS-4562
Repository: mesos
Description (updated)
-------
The "Starting" and "Running" counts show the number of tasks in
"TASK_STARTING" and "TASK_RUNNING" state respectively.
Diffs (updated)
-----
src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3
Diff: https://reviews.apache.org/r/42986/diff/
Testing
-------
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
Re: Review Request 42986: Updated webui to show count for tasks in
`TASK_RUNNING` state.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/
-----------------------------------------------------------
(Updated Jan. 30, 2016, 7:28 p.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Changes
-------
Updated variable names.
Bugs: MESOS-4562
https://issues.apache.org/jira/browse/MESOS-4562
Repository: mesos
Description (updated)
-------
Previously, it was showing the count for tasks in `TASK_STARTING` state.
Also, renamed "Started" to "Running" in the webui.
Diffs (updated)
-----
src/webui/master/static/home.html f6d2f7d0923553ba0bb88e52f541c4e8c740c7c1
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
src/webui/master/static/slave.html ad37ee2d1fab60e40762bf8c313754e1c59fe2a3
Diff: https://reviews.apache.org/r/42986/diff/
Testing
-------
Launched 100 sleeps tasks and verified the status in webui.
Thanks,
Kapil Arya
Re: Review Request 42986: Updated webui to show count for tasks in
`TASK_RUNNING` state.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42986/#review117110
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/webui/master/static/js/controllers.js (line 226)
<https://reviews.apache.org/r/42986/#comment178194>
should we also change the variable name here?
- haosdent huang
On Jan. 29, 2016, 11:29 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42986/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 11:29 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-4562
> https://issues.apache.org/jira/browse/MESOS-4562
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, it was showing the count for tasks in `TASK_STARTING` state.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
>
> Diff: https://reviews.apache.org/r/42986/diff/
>
>
> Testing
> -------
>
> Launched 100 sleeps tasks and verified the status in webui.
>
>
> Thanks,
>
> Kapil Arya
>
>