[GitHub] [kyuubi] cfmcgrady commented on a diff in pull request #4035: Post SparkOperationEvent for ExecuteScala & ExecutePython

[GitBox <gi...@apache.org>]

cfmcgrady commented on code in PR #4035:
URL: https://github.com/apache/kyuubi/pull/4035#discussion_r1058020453


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecutePython.scala:
##########
@@ -167,6 +172,11 @@ class ExecutePython(
       }
     }
   }
+
+  override protected def setState(newState: OperationState): Unit = {

Review Comment:
   Why not override method `setState` on the superclass `SparkOperation`, then all the operations can be seen in the tab. cc @cxzl25 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org