You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2025/11/15 16:03:30 UTC
[PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
wangyum opened a new pull request, #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097
## What changes are proposed in this pull request?
Adds Scala binary version suffix to the published artifactId and fixes shaded jar classifier attachment to include OS, architecture, Spark version.
Example usage of the new shaded classifiers.
Maven (choose one classifier matching your platform / build variant):
```xml
<dependency>
<groupId>org.apache.gluten</groupId>
<artifactId>gluten-package_2.12</artifactId>
<version>1.6.0-SNAPSHOT</version>
<classifier>velox-spark3.5-darwin_aarch64</classifier>
</dependency>
```
SBT:
```scala
libraryDependencies += "org.apache.gluten" % "gluten-package_2.12" % "1.6.0-SNAPSHOT" classifier "velox-spark3.5-darwin_aarch64"
```
Gradle (Groovy DSL):
```groovy
dependencies {
implementation("org.apache.gluten:gluten-package_2.12:1.6.0-SNAPSHOT:velox-spark3.5-darwin_aarch64")
}
```
## How was this patch tested?
Manual test. Examples now generated:
```
-rw-r--r--@ 1 wangyum staff 10249 Nov 15 23:55 gluten-package_2.12-1.6.0-SNAPSHOT-3.5.jar
-rw-r--r--@ 1 wangyum staff 10116530 Nov 15 23:43 gluten-package_2.12-1.6.0-SNAPSHOT-darwin_aarch64-spark3.5-sources.jar
-rw-r--r--@ 1 wangyum staff 36496314 Nov 15 23:43 gluten-package_2.12-1.6.0-SNAPSHOT-darwin_aarch64-spark3.5.jar
-rw-r--r--@ 1 wangyum staff 10116530 Nov 15 23:55 gluten-package_2.12-1.6.0-SNAPSHOT-velox-spark3.5-darwin_aarch64-sources.jar
-rw-r--r--@ 1 wangyum staff 36496315 Nov 15 23:55 gluten-package_2.12-1.6.0-SNAPSHOT-velox-spark3.5-darwin_aarch64.jar
-rw-r--r--@ 1 wangyum staff 10249 Nov 15 23:54 gluten-package_2.12-1.6.0-SNAPSHOT.jar
-rw-r--r--@ 1 wangyum staff 36496315 Nov 15 23:55 gluten-velox-bundle-spark3.5_2.12-darwin_aarch64-1.6.0-SNAPSHOT.jar
drwxr-xr-x@ 3 wangyum staff 96 Nov 15 23:54 maven-archiver
drwxr-xr-x@ 3 wangyum staff 96 Nov 15 23:54 maven-shared-archive-resources
drwxr-xr-x@ 4 wangyum staff 128 Nov 15 23:54 scala-2.12
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3736657734
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11097: [GLUTEN-11096] Add scala.binary.version to gluten-package
URL: https://github.com/apache/incubator-gluten/pull/11097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3542040859
Thanks. Does this work with Spark `--packages`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3536634207
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3538834348
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on code in PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#discussion_r2529974247
##########
dev/change-scala-version.sh:
##########
@@ -13,6 +14,42 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-#
-mock-maker-inline
\ No newline at end of file
+set -e
+
+VALID_VERSIONS=( 2.12 2.13 )
+
+usage() {
+ echo "Usage: $(basename $0) [-h|--help] <version>
+where :
+ -h| --help Display this help text
+ valid version values : ${VALID_VERSIONS[*]}
+" 1>&2
+ exit 1
+}
+
+if [[ ($# -ne 1) || ( $1 == "--help") || $1 == "-h" ]]; then
+ usage
+fi
+
+TO_VERSION=$1
+
+check_scala_version() {
+ for i in ${VALID_VERSIONS[*]}; do [ $i = "$1" ] && return 0; done
+ echo "Invalid Scala version: $1. Valid versions: ${VALID_VERSIONS[*]}" 1>&2
+ exit 1
+}
+
+check_scala_version "$TO_VERSION"
+
+if [ $TO_VERSION = "2.13" ]; then
+ FROM_VERSION="2.12"
+else
+ FROM_VERSION="2.13"
+fi
+
+sed_i() {
+ sed -e "$1" "$2" > "$2.tmp" && mv "$2.tmp" "$2"
+}
+
+sed_i 's/\(artifactId.*\)_'$FROM_VERSION'/\1_'$TO_VERSION'/g' package/pom.xml
Review Comment:
This file copy from https://github.com/apache/spark/blob/master/dev/change-scala-version.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3538818278
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3538860894
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3536623626
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3537215116
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3704332815
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3536631969
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3536630514
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3537185139
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-11096] Add scala.binary.version to gluten-package [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11097:
URL: https://github.com/apache/incubator-gluten/pull/11097#issuecomment-3537173580
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org