[jira] [Commented] (ISIS-2504) JDO: remove datasource configuration hook, instead configure datasources the Spring way

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275882#comment-17275882 ] 

ASF subversion and git services commented on ISIS-2504:
-------------------------------------------------------

Commit 45cabc103bcd9ab0ae34a2402781652e716ca248 in isis's branch refs/heads/ISIS-2476 from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=45cabc1 ]

ISIS-2504: rename config option
isis.persistence.jpa -> isis.persistence.schema

in preparation to also use it with JDO

> JDO: remove datasource configuration hook, instead configure datasources the Spring way
> ---------------------------------------------------------------------------------------
>
>                 Key: ISIS-2504
>                 URL: https://issues.apache.org/jira/browse/ISIS-2504
>             Project: Isis
>          Issue Type: Improvement
>          Components: Isis Persistence JDO
>            Reporter: Andi Huber
>            Assignee: Andi Huber
>            Priority: Major
>             Fix For: 2.0.0-M5
>
>
> UPDATE: original goal as described below, was discarded as it seems not worth the effort for now.
> With JPA we solved this by letting developers configure the list of auto-created schemas explicitly. While with JDO it still requires the logic to have access to the datasource configuration early, hence using IsisConfiguration for that.
> In Isis v1.x we copied all config params residing under the key "isis.persistence.jdo-datanucleus.impl" over to the DN bootstrapping; that logic still exists and should probably be removed.
> Should allow to further simplify the JDO integration (remove the class listener for JDO).
> If current configuration option isis.persistence.jpa is generic enough to also work for jdo, then instead of having 2 variants (jdo/jpa) we can just combine these into eg. isis.persistence.schema?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)