You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/11 09:23:51 UTC

[GitHub] [airflow] danarwix opened a new pull request #18881: refactor connection tests

danarwix opened a new pull request #18881:
URL: https://github.com/apache/airflow/pull/18881


   TLDR;
   refactoring to give a given->when->than testing structure
   https://martinfowler.com/bliki/GivenWhenThen.html
   
   When working on adding the `verify` parameter on https://github.com/apache/airflow/pull/18791, i have noticed that in each test i see the following:
   
   1. `assert mock_connect.return_value == conn` -> that line did not effect the test. inherently, that test ensured that the `MagicMock` equals the `MagicMock` which did not contribute anything to the test itself
   2. mocking the connection -> ```python
   mock_get_connection.return_value = Connection(
               login='login', password='password', host='host', schema='hive'
           )
   ```
   is constantly repeated so i extracted it to a function called: `get_get_connection_return_value(mock_get_connection, extra=None, password=None)`
   3. asserting the parameters in which the connection is called was also extracted to a function called: `assert_connection_called_with(mock_connect, auth=None, verify=True)`
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #18881: refactor trino hook connection tests

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18881:
URL: https://github.com/apache/airflow/pull/18881


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] danarwix commented on pull request #18881: refactor trino hook connection tests

Posted by GitBox <gi...@apache.org>.
danarwix commented on pull request #18881:
URL: https://github.com/apache/airflow/pull/18881#issuecomment-940397564


   @eladkal Thanks for the approval.
   Seems like i dont have write permissions.
   Can you please merge the PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #18881: refactor trino hook connection tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18881:
URL: https://github.com/apache/airflow/pull/18881#issuecomment-940329939


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org