You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/10/10 14:05:05 UTC
[GitHub] [kibble] turbaszek opened a new pull request #47: Introduce github actions for CI
turbaszek opened a new pull request #47:
URL: https://github.com/apache/kibble/pull/47
This is a followup PR for #44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707225900
> GitHub actions should already be enabled for Kibble
Hm, interesting. @Humbedooh do we "Allow all actions" or only "Allow local actions only"? The yaml is ok as the CI is running on my fork:
https://github.com/PolideaInternal/kibble/actions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf merged pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
sharanf merged pull request #47:
URL: https://github.com/apache/kibble/pull/47
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707313496
> Both org and local setting is "allow all", so I dunno. But we'll see if it'll run once we merge, I guess :)
Yup, here's reply from Github support:
> I'm showing that the forked repository has GitHub Actions workflow files, but I'm not seeing any on the main repository.
>
> You will need to merge your change that adds the ci.yml file to the main repository before it will be able to start running the action when you perform pull_request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek closed pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek closed pull request #47:
URL: https://github.com/apache/kibble/pull/47
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707169603
@Humbedooh any update on the possibility of turning on Github Actions for the Apache Kibble project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-708370744
Hi all, is there anything that should be done to get this PR merged? @Humbedooh @sharanf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
sharanf commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-706556753
@turbaszek I have requested a review from @Humbedooh who is part of the the ASF Infra team so if there is anything we missing I am sure he will let us know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] TobKed commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707294434
> @TobKed you are GA expert, any ideas why GA doesn't want to start? 😄
I am not 100% sure but I think it will not run before merging. @Humbedooh is it possible that "Allow local actions only" is overridden by organization settings which may be "Allow all actions"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf edited a comment on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
sharanf edited a comment on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-706556753
@turbaszek I have requested a review from @Humbedooh who is part of the ASF Infra team so if there is anything missing I am sure he will let us know :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707240203
@TobKed you are GA expert, any ideas why GA doesn't want to start? 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] Humbedooh commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707297663
Both org and local setting is "allow all", so I dunno. But we'll see if it'll run once we merge, I guess :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707314973
@Humbedooh so it seems we need to merge it to see CI up and running 🤷♂️ This will require a follow-up PR that will make CI green - I can make it asap after merging this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] Humbedooh commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707171286
GitHub actions should already be enabled for Kibble
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
sharanf commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-709930724
Hi @turbaszek as @Humbedooh has already given feedback on this I am happy to merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-706554723
@sharanf can we please ask infra team to turn on Github Actions for Apache Kibble project? It cannot be configured via `.asf.yaml` file.
The CI seems to be working on my fork:
https://github.com/PolideaInternal/kibble/runs/1235577492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] sharanf edited a comment on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
sharanf edited a comment on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-706556753
@turbaszek I have requested a review from @Humbedooh who is part of the ASF Infra team so if there is anything we missing I am sure he will let us know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] Humbedooh commented on pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #47:
URL: https://github.com/apache/kibble/pull/47#issuecomment-707226384
Its allow all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] Humbedooh commented on a change in pull request #47: Introduce github actions for CI
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on a change in pull request #47:
URL: https://github.com/apache/kibble/pull/47#discussion_r503701070
##########
File path: CONTRIBUTING.md
##########
@@ -17,3 +17,29 @@ We also have:
This project requires Python in higher version than 3.4.
More information will come soon!
+
+## Code Quality
+
+Apache Kibble project is using [pre-commits](https://pre-commit.com) to ensure the quality of the code.
+We encourage you to use pre-commits, but it's not a required to contribute. Every change is checked
Review comment:
Should be either `it's not required in order to contribute` or `it's not a requirement in order to contribute`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org