You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/12/02 21:16:32 UTC
[GitHub] [tinkerpop] spmallette opened a new pull request #1368: TINKERPOP-2438 Improved performance of GremlinASTChecker
spmallette opened a new pull request #1368:
URL: https://github.com/apache/tinkerpop/pull/1368
https://issues.apache.org/jira/browse/TINKERPOP-2438
Used CompileStatic annotation and introduced a lightweight check to validate that there was reason to accept the expense of parsing. It's a bit of a hack in a sense but after some analysis it seems that there are no easy fixes. Everything ends in fairly advanced refactoring and extension of GremlinGroovyScriptEngine and GremlinGroovyClassLoader (with possible pull requests to Groovy). That seems like a fair bit of effort for what this feature is and I'm not sure it's worth it. The typical use case for timeout setting should not encounter the performance problem that would ensue from parsing to the Groovy AST.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1368: TINKERPOP-2438 Improved performance of GremlinASTChecker
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1368:
URL: https://github.com/apache/tinkerpop/pull/1368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org