You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/06/17 22:49:05 UTC
Review Request 70868: Clarified ERROR event as first event in the
scheduler HTTP API docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70868/
-----------------------------------------------------------
Review request for mesos, Greg Mann, James DeFelice, and Vinod Kone.
Repository: mesos
Description
-------
The ERROR event is also possible as the first event in the streaming
response from the master, but this is not clear in the documentation
as pointed out by James DeFelice (james.defelice@gmail.com).
Diffs
-----
docs/scheduler-http-api.md a5327c229142267836f327f9c382ef50b7e334db
Diff: https://reviews.apache.org/r/70868/diff/1/
Testing
-------
N/A
Thanks,
Benjamin Mahler
Re: Review Request 70868: Clarified ERROR event as first event in the
scheduler HTTP API docs.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70868/#review215926
-----------------------------------------------------------
docs/scheduler-http-api.md
Lines 644 (patched)
<https://reviews.apache.org/r/70868/#comment302870>
Actually, we made the `UPDATE_FRAMEWORK` call return an appropriate response code so remove this example.
- Benjamin Mahler
On June 17, 2019, 10:49 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70868/
> -----------------------------------------------------------
>
> (Updated June 17, 2019, 10:49 p.m.)
>
>
> Review request for mesos, Greg Mann, James DeFelice, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The ERROR event is also possible as the first event in the streaming
> response from the master, but this is not clear in the documentation
> as pointed out by James DeFelice (james.defelice@gmail.com).
>
>
> Diffs
> -----
>
> docs/scheduler-http-api.md a5327c229142267836f327f9c382ef50b7e334db
>
>
> Diff: https://reviews.apache.org/r/70868/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 70868: Clarified ERROR event as first event in the
scheduler HTTP API docs.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70868/#review215925
-----------------------------------------------------------
Ship it!
Ship It!
- James DeFelice
On June 17, 2019, 10:49 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70868/
> -----------------------------------------------------------
>
> (Updated June 17, 2019, 10:49 p.m.)
>
>
> Review request for mesos, Greg Mann, James DeFelice, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The ERROR event is also possible as the first event in the streaming
> response from the master, but this is not clear in the documentation
> as pointed out by James DeFelice (james.defelice@gmail.com).
>
>
> Diffs
> -----
>
> docs/scheduler-http-api.md a5327c229142267836f327f9c382ef50b7e334db
>
>
> Diff: https://reviews.apache.org/r/70868/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>