[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8590: Fix the upsert metadata bug when adding segment with same comparison value

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8590:
URL: https://github.com/apache/pinot/pull/8590#discussion_r859070636


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -103,13 +103,14 @@ public void addSegment(IndexSegment segment, Iterator<RecordInfo> recordInfoIter
           (primaryKey, currentRecordLocation) -> {
             if (currentRecordLocation != null) {
               // Existing primary key
+              IndexSegment currentSegment = currentRecordLocation.getSegment();
+              int comparisonResult = recordInfo._comparisonValue.compareTo(currentRecordLocation.getComparisonValue());

Review Comment:
   line 140 in the old code (using `==` instead of `equals()` for boxed value)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org