You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/16 14:33:03 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4936: Reduce the length of metric name

wu-sheng commented on a change in pull request #4936:
URL: https://github.com/apache/skywalking/pull/4936#discussion_r440898364



##########
File path: test/e2e/e2e-test/docker/base-compose.yml
##########
@@ -34,6 +34,8 @@ services:
       SW_STORAGE_INFLUXDB_URL: http://influxdb:8086
       JAVA_OPTS: >-
         -javaagent:/jacoco/jacocoagent.jar=classdumpdir=/jacoco/classes/oap,destfile=/jacoco/oap.exec,includes=org.apache.skywalking.*,excludes=org.apache.skywalking.oap.query.*:org.apache.skywalking.oap.server.core.query.*
+      SW_PROMETHEUS_FETCHER_ACTIVE: true
+      SW_TELEMETRY: prometheus

Review comment:
       This should be able to open self-observation. But I think we should add GraphQL query to verify the metrics really have values. NOTICE, usually, metrics value should not be 0, if there are some cases of that, we could skip those metrics, such as GC count/time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org