[GitHub] [spark] MaxGekk commented on a change in pull request #32271: [SPARK-35112]][SQL] Support Cast string to day-second interval

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #32271:
URL: https://github.com/apache/spark/pull/32271#discussion_r617415668



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -123,6 +123,24 @@ object IntervalUtils {
     }
   }
 
+  def safeFromDayTimeString(input: UTF8String): Option[Long] = {
+    try {
+      if (input == null || input.toString == null) {
+        throw new IllegalArgumentException("Interval day-second string must be not null")
+      } else {
+        val regex = "INTERVAL '([-|+]?[0-9]+ [0-9:]+)' DAY TO SECOND".r
+        // scalastyle:off caselocale .toLowerCase
+        val intervalString = input.trimAll().toUpperCase.toString

Review comment:
       I think you can make the regexp case insensitive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org