You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2015/11/16 11:08:16 UTC
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/9732
[SPARK-11755] [R] SparkR should export "predict"
R users often get help information for a method like this:
```R
> ?predict
```
or
```R
> help(predict)
```
For SparkR we should provide the help information for the SparkR package and base R package(usually stats package).
But for "predict" method, it can only output the help information from package:stats.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark spark-11755
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9732.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9732
----
commit 09998a3ae028a6a48d7ddc81a6d7e36482f119a5
Author: Yanbo Liang <yb...@gmail.com>
Date: 2015-11-16T10:06:32Z
SparkR should export predict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/9732#issuecomment-156978307
@mengxr @shivaram @sun-rui
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9732#issuecomment-156985142
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45993/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9732#issuecomment-156979683
**[Test build #45993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45993/consoleFull)** for PR 9732 at commit [`09998a3`](https://github.com/apache/spark/commit/09998a3ae028a6a48d7ddc81a6d7e36482f119a5).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9732#discussion_r44952987
--- Diff: R/pkg/R/generics.R ---
@@ -1054,6 +1054,10 @@ setGeneric("year", function(x) { standardGeneric("year") })
#' @export
setGeneric("glm")
+#' @rdname predict
+#' @export
+setGeneric("predict", function(object, newData) { standardGeneric("predict") })
--- End diff --
Yeah we should follow the same signature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9732#issuecomment-156985136
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9732#issuecomment-156985000
**[Test build #45993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45993/consoleFull)** for PR 9732 at commit [`09998a3`](https://github.com/apache/spark/commit/09998a3ae028a6a48d7ddc81a6d7e36482f119a5).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11755] [R] SparkR should export "predic...
Posted by sun-rui <gi...@git.apache.org>.
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9732#discussion_r44911837
--- Diff: R/pkg/R/generics.R ---
@@ -1054,6 +1054,10 @@ setGeneric("year", function(x) { standardGeneric("year") })
#' @export
setGeneric("glm")
+#' @rdname predict
+#' @export
+setGeneric("predict", function(object, newData) { standardGeneric("predict") })
--- End diff --
It may be better to keep the signature of "predict" to be same as that in R base.
```
setGeneric("predict", function(object, ...) { standardGeneric("predict") })
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org