[GitHub] [pinot] jackjlli commented on pull request #9001: Remove double counting of queries in pinot-server

[GitBox <gi...@apache.org>]

jackjlli commented on PR #9001:
URL: https://github.com/apache/pinot/pull/9001#issuecomment-1174068840

   > Aren't both of these metrics under different groups? The one removed in this PR is for `tableNameWithType` but the one not removed [in the mentioned link](https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java#L111) is under global group i.e. combined metric for all the tables.
   
   Good question! If you take a look at the metric definition, the 2nd parameter is `true`, which means that the metric is a global metric. 
   https://github.com/apache/pinot/blob/09fcdd59cc07e2faa154858075473cdec3518b60/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java#L28
   
   Plus, the metric is only emitted in `PriorityScheduler` but not in other ones. If we really want a table level metrics, it'd be good to add a new one and add it to all the schedulers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org