You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Kevin Huang (JIRA)" <ji...@apache.org> on 2008/10/24 03:21:44 UTC

[jira] Created: (FELIX-791) To include filtered resouces in the final jar

To include filtered resouces in the final jar
---------------------------------------------

                 Key: FELIX-791
                 URL: https://issues.apache.org/jira/browse/FELIX-791
             Project: Felix
          Issue Type: New Feature
          Components: Maven Bundle Plugin
    Affects Versions: maven-bundle-plugin-1.4.3
         Environment: Windows XP
            Reporter: Kevin Huang
            Priority: Minor


The bundle plugin currently ignores the filtered resources generated by the maven filter and instead incorporates the unfiltered files from the src directory. It would be good to induce a change to allow the filtered resources to be included in the final jar.

Currently a way around the issue would involve generating the manifest file only and use the maven-jar-plugin to create the final jar. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-791) To include filtered resouces in the final jar

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668536#action_12668536 ] 

Stuart McCulloch commented on FELIX-791:
----------------------------------------

Could you supply a testcase where the resources aren't being filtered properly? Resource files discovered by the maven-bundle-plugin should be filtered, but it will be Bnd doing the filtering rather than just taking the processed resource from target/classes (this was a specific design decision that was discussed about a year ago).

> To include filtered resouces in the final jar
> ---------------------------------------------
>
>                 Key: FELIX-791
>                 URL: https://issues.apache.org/jira/browse/FELIX-791
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-1.4.3
>         Environment: Windows XP
>            Reporter: Kevin Huang
>            Priority: Minor
>
> The bundle plugin currently ignores the filtered resources generated by the maven filter and instead incorporates the unfiltered files from the src directory. It would be good to induce a change to allow the filtered resources to be included in the final jar.
> Currently a way around the issue would involve generating the manifest file only and use the maven-jar-plugin to create the final jar. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-791) To include filtered resouces in the final jar

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673833#action_12673833 ] 

Stuart McCulloch commented on FELIX-791:
----------------------------------------

Any update on the testcase?  Local testing with the 1.4.3 bundleplugin shows resources are filtered by BND if you have filtering turned on in the relevant Maven resource section, for example:

  <build>
    <resources>
      <resource>
        <filtering>true</filtering>
        <directory>src/main/resources</directory>
      </resource>
    </resources>
  </build>


> To include filtered resouces in the final jar
> ---------------------------------------------
>
>                 Key: FELIX-791
>                 URL: https://issues.apache.org/jira/browse/FELIX-791
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-1.4.3
>         Environment: Windows XP
>            Reporter: Kevin Huang
>            Priority: Minor
>
> The bundle plugin currently ignores the filtered resources generated by the maven filter and instead incorporates the unfiltered files from the src directory. It would be good to induce a change to allow the filtered resources to be included in the final jar.
> Currently a way around the issue would involve generating the manifest file only and use the maven-jar-plugin to create the final jar. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-791) To include filtered resouces in the final jar

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stuart McCulloch resolved FELIX-791.
------------------------------------

    Resolution: Cannot Reproduce

Tagging as unable to reproduce, need a testcase from the reporter in order to continue the investigation.

> To include filtered resouces in the final jar
> ---------------------------------------------
>
>                 Key: FELIX-791
>                 URL: https://issues.apache.org/jira/browse/FELIX-791
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-1.4.3
>         Environment: Windows XP
>            Reporter: Kevin Huang
>            Priority: Minor
>
> The bundle plugin currently ignores the filtered resources generated by the maven filter and instead incorporates the unfiltered files from the src directory. It would be good to induce a change to allow the filtered resources to be included in the final jar.
> Currently a way around the issue would involve generating the manifest file only and use the maven-jar-plugin to create the final jar. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.