You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2014/03/10 19:46:47 UTC
Re: Review Request 18976: One-line fix for MESOS-1078: JNI calls hasNext on
ArrayList instead of iterator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18976/
-----------------------------------------------------------
(Updated March 10, 2014, 11:46 a.m.)
Review request for mesos.
Changes
-------
Expanded summary
Summary (updated)
-----------------
One-line fix for MESOS-1078: JNI calls hasNext on ArrayList instead of iterator
Bugs: MESOS-1078
https://issues.apache.org/jira/browse/MESOS-1078
Repository: mesos-git
Description
-------
Apparently a typical copy-paste mistake of the programmer of this code.
Diffs
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d2369ac
Diff: https://reviews.apache.org/r/18976/diff/
Testing
-------
Please allow me to submit this without writing a unit test against it. That would be overkill IMHO for such an obvious fix.
We have an internal app at Mesosphere that we cannot share unfortunately that used to crash and now works.
Thanks,
Bernd Mathiske
Re: Review Request 18976: One-line fix for MESOS-1078: JNI calls hasNext on
ArrayList instead of iterator
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18976/#review36681
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On March 10, 2014, 11:46 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18976/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 11:46 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1078
> https://issues.apache.org/jira/browse/MESOS-1078
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Apparently a typical copy-paste mistake of the programmer of this code.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d2369ac
>
> Diff: https://reviews.apache.org/r/18976/diff/
>
>
> Testing
> -------
>
> Please allow me to submit this without writing a unit test against it. That would be overkill IMHO for such an obvious fix.
>
> We have an internal app at Mesosphere that we cannot share unfortunately that used to crash and now works.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18976: One-line fix for MESOS-1078: JNI calls hasNext on
ArrayList instead of iterator
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18976/#review36692
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18976]
All tests passed.
- Mesos ReviewBot
On March 10, 2014, 6:56 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18976/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 6:56 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1078
> https://issues.apache.org/jira/browse/MESOS-1078
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Apparently a typical copy-paste mistake of the programmer of this code.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d2369ac
>
> Diff: https://reviews.apache.org/r/18976/diff/
>
>
> Testing
> -------
>
> Please allow me to submit this without writing a unit test against it. That would be overkill IMHO for such an obvious fix.
>
> We have an internal app at Mesosphere that we cannot share unfortunately that used to crash and now works.
>
>
> Thanks,
>
> Bernd Mathiske
>
>
Re: Review Request 18976: One-line fix for MESOS-1078: JNI calls hasNext on
ArrayList instead of iterator
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18976/
-----------------------------------------------------------
(Updated March 10, 2014, 6:56 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
assigning to @niklas for shepherding this. -- Vinod
Bugs: MESOS-1078
https://issues.apache.org/jira/browse/MESOS-1078
Repository: mesos-git
Description
-------
Apparently a typical copy-paste mistake of the programmer of this code.
Diffs
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d2369ac
Diff: https://reviews.apache.org/r/18976/diff/
Testing
-------
Please allow me to submit this without writing a unit test against it. That would be overkill IMHO for such an obvious fix.
We have an internal app at Mesosphere that we cannot share unfortunately that used to crash and now works.
Thanks,
Bernd Mathiske
Re: Review Request 18976: One-line fix for MESOS-1078: JNI calls hasNext on
ArrayList instead of iterator
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18976/#review36683
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 10, 2014, 6:46 p.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18976/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 6:46 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1078
> https://issues.apache.org/jira/browse/MESOS-1078
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Apparently a typical copy-paste mistake of the programmer of this code.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d2369ac
>
> Diff: https://reviews.apache.org/r/18976/diff/
>
>
> Testing
> -------
>
> Please allow me to submit this without writing a unit test against it. That would be overkill IMHO for such an obvious fix.
>
> We have an internal app at Mesosphere that we cannot share unfortunately that used to crash and now works.
>
>
> Thanks,
>
> Bernd Mathiske
>
>