[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9983: [multistage][bugfix] fixing empty response unable to convert issue

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9983:
URL: https://github.com/apache/pinot/pull/9983#discussion_r1047844145


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/BaseResultsBlock.java:
##########
@@ -158,6 +158,11 @@ public void setNumServerThreads(int numServerThreads) {
     _numServerThreads = numServerThreads;
   }
 
+  /**
+   * Indicate the size of the result.
+   */
+  public abstract long getNumRecords();

Review Comment:
   (minor) Suggest returning `int` as we cannot return a collection of over 2B records. Also suggest renaming to `getNumRows()` to be more clear that it indicates the size of `getRows()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org