You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Si Chen (JIRA)" <ji...@apache.org> on 2007/02/14 01:35:06 UTC
[jira] Commented: (OFBIZ-659) Refactoring Create Order process
[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472948 ]
Si Chen commented on OFBIZ-659:
-------------------------------
Is the plan actually to re-write the checkout process in minilang?
> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-659) Refactoring Create Order process
Posted by Si Chen <si...@opensourcestrategies.com>.
Anil Patel wrote:
> Yes. I will like to have small simple methods for order process steps.
>
>
> On 2/13/07, Si Chen (JIRA) <ji...@apache.org> wrote:
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472948
>>
>> ]
>>
>> Si Chen commented on OFBIZ-659:
>> -------------------------------
>>
>> Is the plan actually to re-write the checkout process in minilang?
>>
>> > Refactoring Create Order process
>> > --------------------------------
>> >
>> > Key: OFBIZ-659
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-659
>> > Project: OFBiz (The Open for Business Project)
>> > Issue Type: Improvement
>> > Components: order
>> > Reporter: Anil K Patel
>> > Attachments: OrderChekOutProcessRefac.patch,
>> OrderProcessSimpleMethods.patch
>> >
>> >
>> > Focus of this Jira Issue is Refactoring Create Order Process,
>> Implement a
>> parallel code as needed so that the current Code remains intact.
>> > From David's email on Mailing list.
>> > Just some quick thoughts...
>> > Following the pattern of the anonymous and other checkout processes
>> > in the ecommerce app would be a great way to go.
>> > In the order manager there are various paths through the checkout
>> > process so we might have, for example, 2 different sets of request-
>> > map definitions and two different "progress bars", one for sales
>> > orders and one for purchase orders. These two different sets of high-
>> > level artifacts can point to the same views, services/events,
>> > screens, data prep scripts, etc wherever the two processes overlap.
>> > -David
>> > My Initial comments
>> > The anonymous checkout process in Ecommerce component provides some
>> high
>> level guiding principals. Few things that I can think of are
>> > 1) moving some code that's embedded in Java classes into small simple
>> methods.
>> > 2) Moving process control logic from event handlers to Controller
>> file.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Anil,
We've already had a discussion about reimplementing the checkout in
minilang. See:
http://issues.apache.org/jira/browse/OFBIZ-499
Si
Re: [jira] Commented: (OFBIZ-659) Refactoring Create Order process
Posted by Anil Patel <to...@gmail.com>.
Yes. I will like to have small simple methods for order process steps.
On 2/13/07, Si Chen (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472948
> ]
>
> Si Chen commented on OFBIZ-659:
> -------------------------------
>
> Is the plan actually to re-write the checkout process in minilang?
>
> > Refactoring Create Order process
> > --------------------------------
> >
> > Key: OFBIZ-659
> > URL: https://issues.apache.org/jira/browse/OFBIZ-659
> > Project: OFBiz (The Open for Business Project)
> > Issue Type: Improvement
> > Components: order
> > Reporter: Anil K Patel
> > Attachments: OrderChekOutProcessRefac.patch,
> OrderProcessSimpleMethods.patch
> >
> >
> > Focus of this Jira Issue is Refactoring Create Order Process, Implement a
> parallel code as needed so that the current Code remains intact.
> > From David's email on Mailing list.
> > Just some quick thoughts...
> > Following the pattern of the anonymous and other checkout processes
> > in the ecommerce app would be a great way to go.
> > In the order manager there are various paths through the checkout
> > process so we might have, for example, 2 different sets of request-
> > map definitions and two different "progress bars", one for sales
> > orders and one for purchase orders. These two different sets of high-
> > level artifacts can point to the same views, services/events,
> > screens, data prep scripts, etc wherever the two processes overlap.
> > -David
> > My Initial comments
> > The anonymous checkout process in Ecommerce component provides some high
> level guiding principals. Few things that I can think of are
> > 1) moving some code that's embedded in Java classes into small simple
> methods.
> > 2) Moving process control logic from event handlers to Controller file.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>