[jira] [Commented] (CALCITE-1719) SortCollapseRule for collapsing nested sorts

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937060#comment-15937060 ] 

Julian Hyde commented on CALCITE-1719:
--------------------------------------

Does this rule rely on the output of the lower sort being sorted? (It may sound crazy, but it's dangerous to assume any physical properties of a relation, even the fact that Sort produces sorted output.)

In new planner tests, please use something like {{(sql).with(program).check()}} rather than {{checkPlanning}}.

Also follow the coding style. Close parens on the same line, indent arguments by 4 spaces rather than aligning with open paren. Also break long SQL strings.


> SortCollapseRule for collapsing nested sorts
> --------------------------------------------
>
>                 Key: CALCITE-1719
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1719
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Gian Merlino
>            Assignee: Julian Hyde
>
> Useful for subqueries like {{SELECT * FROM (...) LIMIT X}}, where the inner
> query might have an order by or limit.
> Patch in https://github.com/apache/calcite/pull/410.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)