You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2018/08/30 13:55:00 UTC

[jira] [Commented] (OAK-7720) Log hex dump of too big segments

    [ https://issues.apache.org/jira/browse/OAK-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597485#comment-16597485 ] 

Francesco Mari commented on OAK-7720:
-------------------------------------

The first version of the patch prints a single warn log statement containing a message, some metadata about the segment and the hex dump of the segment buffer. The message is quite verbose because of the hex dump, but I think it's an acceptable price to pay in order to efficiently identify segment corruptions. [~mduerig], [~dulceanu], can you review?

> Log hex dump of too big segments
> --------------------------------
>
>                 Key: OAK-7720
>                 URL: https://issues.apache.org/jira/browse/OAK-7720
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>         Attachments: OAK-7720-01.patch
>
>
> {{SegmentBufferWriter}} throws an ISE when it detects that a too big segment is about to be flushed. The ISE contains some details about the segment, like the amount of referenced segments, the amount of records, they payload length and the total length, but they are insufficient. {{SegmentBufferWriter}} should print a hex dump of the segment to the logger in order to speed up the debugging of this error condition.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)