You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2013/05/23 16:58:50 UTC
svn commit: r1485748 -
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java
Author: mduerig
Date: Thu May 23 14:58:50 2013
New Revision: 1485748
URL: http://svn.apache.org/r1485748
Log:
OAK-842: Incorrect interaction of orderable child nodes with access control
add issue reference
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java?rev=1485748&r1=1485747&r2=1485748&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/TreeImpl.java Thu May 23 14:58:50 2013
@@ -241,6 +241,7 @@ public class TreeImpl implements Tree {
if (parent != null && parent.hasChild(name)) {
nodeBuilder.remove();
if (parent.hasOrderableChildren()) {
+ // FIXME (OAK-842) child order not updated when parent is not accessible
parent.nodeBuilder.setProperty(
MemoryPropertyBuilder.copy(STRING, parent.nodeBuilder.getProperty(OAK_CHILD_ORDER))
.removeValue(name)
@@ -523,6 +524,7 @@ public class TreeImpl implements Tree {
* @return the ordered child names.
*/
private Iterable<String> getOrderedChildNames() {
+ // FIXME (OAK-842) take access control restriction into consideration
assert hasOrderableChildren();
return new Iterable<String>() {
@Override