You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ramkumar Vadali (JIRA)" <ji...@apache.org> on 2012/08/31 20:17:07 UTC

[jira] [Created] (HBASE-6704) StoreScanner KV usage improvement

Ramkumar Vadali created HBASE-6704:
--------------------------------------

             Summary: StoreScanner KV usage improvement
                 Key: HBASE-6704
                 URL: https://issues.apache.org/jira/browse/HBASE-6704
             Project: HBase
          Issue Type: Improvement
          Components: regionserver
         Environment: 89-fb
            Reporter: Ramkumar Vadali
            Priority: Trivial


StoreScanner#next tries to ensure that the KVs are pulled from the heap in-order. The prevKV is used for this and is compared with the latest KV pulled from the heap. Since copyKV can be modified by ScanQueryMatcher, prevKV should track the KV pulled from the heap, and not copyKV. This is a one-line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6704) StoreScanner KV usage improvement

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465994#comment-13465994 ] 

Lars Hofhansl commented on HBASE-6704:
--------------------------------------

I thought I had already removed this from 0.94+
                
> StoreScanner KV usage improvement
> ---------------------------------
>
>                 Key: HBASE-6704
>                 URL: https://issues.apache.org/jira/browse/HBASE-6704
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>         Environment: 89-fb
>            Reporter: Ramkumar Vadali
>            Priority: Trivial
>         Attachments: 0001-jira-HBASE-6704-Improve-KV-usage-in-StoreScanner-nex.patch
>
>
> StoreScanner#next tries to ensure that the KVs are pulled from the heap in-order. The prevKV is used for this and is compared with the latest KV pulled from the heap. Since copyKV can be modified by ScanQueryMatcher, prevKV should track the KV pulled from the heap, and not copyKV. This is a one-line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6704) StoreScanner KV usage improvement

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-6704:
-------------------------

    Attachment: 0001-jira-HBASE-6704-Improve-KV-usage-in-StoreScanner-nex.patch

Forward port from 0.89fb branch
                
> StoreScanner KV usage improvement
> ---------------------------------
>
>                 Key: HBASE-6704
>                 URL: https://issues.apache.org/jira/browse/HBASE-6704
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>         Environment: 89-fb
>            Reporter: Ramkumar Vadali
>            Priority: Trivial
>         Attachments: 0001-jira-HBASE-6704-Improve-KV-usage-in-StoreScanner-nex.patch
>
>
> StoreScanner#next tries to ensure that the KVs are pulled from the heap in-order. The prevKV is used for this and is compared with the latest KV pulled from the heap. Since copyKV can be modified by ScanQueryMatcher, prevKV should track the KV pulled from the heap, and not copyKV. This is a one-line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-6704) StoreScanner KV usage improvement

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-6704.
--------------------------

    Resolution: Won't Fix

Already done by Lars (Sorry, I thought I looked first before posting... but must have looked in wrong place).
                
> StoreScanner KV usage improvement
> ---------------------------------
>
>                 Key: HBASE-6704
>                 URL: https://issues.apache.org/jira/browse/HBASE-6704
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>         Environment: 89-fb
>            Reporter: Ramkumar Vadali
>            Priority: Trivial
>         Attachments: 0001-jira-HBASE-6704-Improve-KV-usage-in-StoreScanner-nex.patch
>
>
> StoreScanner#next tries to ensure that the KVs are pulled from the heap in-order. The prevKV is used for this and is compared with the latest KV pulled from the heap. Since copyKV can be modified by ScanQueryMatcher, prevKV should track the KV pulled from the heap, and not copyKV. This is a one-line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6704) StoreScanner KV usage improvement

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446202#comment-13446202 ] 

Ramkumar Vadali commented on HBASE-6704:
----------------------------------------

https://reviews.facebook.net/D5085

                
> StoreScanner KV usage improvement
> ---------------------------------
>
>                 Key: HBASE-6704
>                 URL: https://issues.apache.org/jira/browse/HBASE-6704
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>         Environment: 89-fb
>            Reporter: Ramkumar Vadali
>            Priority: Trivial
>
> StoreScanner#next tries to ensure that the KVs are pulled from the heap in-order. The prevKV is used for this and is compared with the latest KV pulled from the heap. Since copyKV can be modified by ScanQueryMatcher, prevKV should track the KV pulled from the heap, and not copyKV. This is a one-line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira