You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Joris van Lieshout <jv...@schubergphilis.com> on 2014/06/02 10:21:05 UTC

Re: Review Request 22093: VPC's VR missing public NIC eth1

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44479
-----------------------------------------------------------


The issue I see with this fix is that it also applies to other hypvervisors and, as far as I know, this is not broken on, at least, XenServer. Thorough testing will be required.

- Joris van Lieshout


On May 30, 2014, 9 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 9 p.m.)
> 
> 
> Review request for cloudstack and Marcus Sorensen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132 
> 
> Diff: https://reviews.apache.org/r/22093/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>