You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/06/05 18:34:10 UTC
(superset) 01/04: fix(dashboard): unable to resize due to the overlapped droptarget (#28772)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 38fdf23453f0404e055576c6b08a2d6c8de0010d
Author: JUST.in DO IT <ju...@airbnb.com>
AuthorDate: Thu May 30 13:08:33 2024 -0700
fix(dashboard): unable to resize due to the overlapped droptarget (#28772)
(cherry picked from commit ce568c34f99148748a97d0893be976d7cecc3d63)
---
.../src/dashboard/components/DashboardBuilder/DashboardWrapper.tsx | 6 ++++++
.../src/dashboard/components/gridComponents/Column.jsx | 5 +----
superset-frontend/src/dashboard/components/gridComponents/Row.jsx | 3 ---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardWrapper.tsx b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardWrapper.tsx
index 2bcdc5b9cd..0015000162 100644
--- a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardWrapper.tsx
+++ b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardWrapper.tsx
@@ -47,6 +47,12 @@ const StyledDiv = styled.div`
& .grid-row:after {
border-style: hidden;
}
+ & .droptarget-side:last-child {
+ inset-inline-end: 0;
+ }
+ & .droptarget-edge:last-child {
+ inset-block-end: 0;
+ }
}
/* A row within a column has inset hover menu */
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Column.jsx b/superset-frontend/src/dashboard/components/gridComponents/Column.jsx
index 216e9e8e82..98f2b84e8d 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Column.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Column.jsx
@@ -98,9 +98,6 @@ const ColumnStyles = styled.div`
&:first-child {
inset-block-start: 0;
}
- &:last-child {
- inset-block-end: 0;
- }
}
&:first-child:not(.droptarget-edge) {
position: absolute;
@@ -295,7 +292,7 @@ class Column extends React.PureComponent {
className={cx(
'empty-droptarget',
itemIndex === columnItems.length - 1 &&
- 'droptarget-edge-last',
+ 'droptarget-edge',
)}
editMode
>
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
index 2f7a5e541b..bad32d4cdc 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
@@ -107,9 +107,6 @@ const GridRow = styled.div`
&:first-child {
inset-inline-start: 0;
}
- &:last-child {
- inset-inline-end: 0;
- }
}
}