[GitHub] [samza] mynameborat commented on a diff in pull request #1668: SAMZA-2782: Clean up container thread pool DI into StreamOperatorTask

["mynameborat (via GitHub)" <gi...@apache.org>]

mynameborat commented on code in PR #1668:
URL: https://github.com/apache/samza/pull/1668#discussion_r1227032961


##########
samza-core/src/main/java/org/apache/samza/task/StreamOperatorTask.java:
##########
@@ -93,6 +93,11 @@ public StreamOperatorTask(OperatorSpecGraph specGraph) {
   public final void init(Context context) throws Exception {
     // create the operator impl DAG corresponding to the logical operator spec DAG
     this.operatorImplGraph = new OperatorImplGraph(specGraph, context, clock);
+    /*
+     * TODO: Consolidate the thread pool used by OperatorImpl and StreamOperatorTask. For now, we need to keep the
+     * existing behavior. The refactor however is to clean up the DI which is one step towards consolidation
+     */
+    this.taskThreadPool = context.getContainerContext().getContainerThreadPool();

Review Comment:
   It always used container thread pool prior to this refactor as well. There was only one framework thread pool for historic context and hence it always used that one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org