You are viewing a plain text version of this content. The canonical link for it is here.
Posted to submarine-dev@hadoop.apache.org by "Adam Antal (JIRA)" <ji...@apache.org> on 2019/07/10 14:30:00 UTC
[jira] [Commented] (SUBMARINE-49) Add more test coverage to
RunJobParameters
[ https://issues.apache.org/jira/browse/SUBMARINE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882114#comment-16882114 ]
Adam Antal commented on SUBMARINE-49:
-------------------------------------
I'm taking this over, thanks [~snemeth].
Retrigger jenkins with latest patch, and see what else we've got.
> Add more test coverage to RunJobParameters
> ------------------------------------------
>
> Key: SUBMARINE-49
> URL: https://issues.apache.org/jira/browse/SUBMARINE-49
> Project: Hadoop Submarine
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Adam Antal
> Priority: Major
> Attachments: SUBMARINE-49.001.patch, SUBMARINE-49.002.patch, SUBMARINE-49.003.patch, SUBMARINE-49.004.patch, SUBMARINE-49.004.patch, SUBMARINE-49.005.patch, SUBMARINE-49.006.patch, SUBMARINE-49.007.patch, SUBMARINE-49.007.patch
>
>
> There are some good tests in {{org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing}}, but these are not testing all fields set by method {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}.
> Some more extensive testing is needed in this area.
> As an added bonus, the code {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}} could be cleaned up a bit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)