You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/12/16 15:05:55 UTC
[GitHub] [incubator-eventmesh] jinrongluo opened a new issue #658: [Enhancement] Support CloudEvents Webhook Specification
jinrongluo opened a new issue #658:
URL: https://github.com/apache/incubator-eventmesh/issues/658
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
Eventmesh supports CloudEvents Specification. But there is a missing piece of work about Http Webhook for CloudEvents.
https://github.com/cloudevents/spec/blob/v1.0.1/http-webhook.md
To completely meet the CloudEvents Spec, I suggest implement Http Webhook for CloudEvents in EventMesh.
### Describe the solution you'd like
Implement HTTP Webhook for CloudEvents Spec - https://github.com/cloudevents/spec/blob/v1.0.1/http-webhook.md
In HTTP Push -> AsyncHTTPPushRequest class
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on issue #658: [Enhancement] Support CloudEvents Webhook Specification
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on issue #658:
URL: https://github.com/apache/incubator-eventmesh/issues/658#issuecomment-1036442136
Thanks I will contribute PR for this CloudEvents webhook spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on issue #658: [Enhancement] Support CloudEvents Webhook Specification
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #658:
URL: https://github.com/apache/incubator-eventmesh/issues/658#issuecomment-996392257
There are many constraints in this pr. IMO, the most important must-be item is WebHook-Request-Origin, we should care about this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo edited a comment on issue #658: [Enhancement] Support CloudEvents Webhook Specification
Posted by GitBox <gi...@apache.org>.
jinrongluo edited a comment on issue #658:
URL: https://github.com/apache/incubator-eventmesh/issues/658#issuecomment-1036576090
For implementing CloudEvents WebHook Spec, the following items required:
**Delivery Notification Request**
1. use HTTPS when invoking the webhook
2. HTTP Header uses `Content-Type`
3. HTTP Header includes `WebHook-Request-Origin`
**Delivery Notification Response**
1. If delivery is accepted and processed, there is payload in response, Http return Code 200 OK / 201 Created, Response HTTP Header uses `Content-Type`
2. If delivery is accepted and processed and no payload, HTTP return code 201 Created / 204 No Content
3. If delivery is accepted and process status is unknown, HTTP return code 202 Accepted
4. If the delivery is retired and the target returns 410 Gone, Eventmesh should not send further requests
5. If the delivery target not able to process the request due to exceeding request rate limit, it should return 429 Too Many Requests. and include `Retry-After` header. Eventmesh should use this value for next retry
6. If the delivery is not accepted due to the notification format is not understood. it should return 415 Unsupported Media Type
**Authorization**
1. Adding `Authorization` header
**Abuse Protection: Validation Request**
1. include `WebHook-Request-Origin` Http Header
**Abuse Protection: Validation Response**
1. include `WebHook-Allowed-Origin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on issue #658: [Enhancement] Support CloudEvents Webhook Specification
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on issue #658:
URL: https://github.com/apache/incubator-eventmesh/issues/658#issuecomment-1036576090
For implementing CloudEvents WebHook Spec, the following items required:
**Delivery Notification Request**
1. use HTTPS when invoking the webhook
2. HTTP Header uses `Content-Type`
3. HTTP Header includes `WebHook-Request-Origin`
**Delivery Notification Response**
1. If delivery is accepted and processed, there is payload in response, Http return Code 200 OK / 201 Created, Response HTTP Header uses `Content-Type`
2. If delivery is accepted and processed and no payload, HTTP return code 201 Created / 204 No Content
3. If delivery is accepted and process status is unknown, HTTP return code 202 Accepted
4. If the delivery is retired and the target returns 410 Gone, Eventmesh should not send further requests
5. If the delivery target not able to process the request due to exceeding request rate limit, it should return 429 Too Many Requests. and include `Retry-After` header. Eventmesh should use this value for next retry
6. If the delivery is not accepted due to the notification format is not understood. it should return 415 Unsupported Media Type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org