You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/28 03:37:18 UTC
[GitHub] [incubator-hudi] wangxianghu opened a new pull request #1148:
[MINOR] update HoodieTableType.java's javadoc
wangxianghu opened a new pull request #1148: [MINOR] update HoodieTableType.java's javadoc
URL: https://github.com/apache/incubator-hudi/pull/1148
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Update HoodieTableType.java's Javadoc
## Brief change log
The Javadoc says hudi support 1 table type only, actually hudi supports 2 types now
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on issue #1148: [MINOR]
Update the java doc of HoodieTableType
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on issue #1148: [MINOR] Update the java doc of HoodieTableType
URL: https://github.com/apache/incubator-hudi/pull/1148#issuecomment-569470817
ok, thinks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua merged pull request #1148: [MINOR] Update
the java doc of HoodieTableType
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1148: [MINOR] Update the java doc of HoodieTableType
URL: https://github.com/apache/incubator-hudi/pull/1148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1148: [MINOR] Update
the java doc of HoodieTableType
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1148: [MINOR] Update the java doc of HoodieTableType
URL: https://github.com/apache/incubator-hudi/pull/1148#issuecomment-569466545
Two additional tips:
1. Always uppercase the first letter of the commit message(and the first letter of the title of the PR) ;
2. It would be better to avoid containing `'` in the whole commit message, because it may break the commit message;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services