You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ch...@apache.org on 2018/06/29 00:11:58 UTC
mesos git commit: Fixed flaky test
`DefaultExecutorTest.SigkillExecutor`.
Repository: mesos
Updated Branches:
refs/heads/master 40188e68e -> 90c5c0b41
Fixed flaky test `DefaultExecutorTest.SigkillExecutor`.
Fixed flaky test `DefaultExecutorTest.SigkillExecutor`
by setting action to ignore subsequent offer calls.
Review: https://reviews.apache.org/r/67778/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/90c5c0b4
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/90c5c0b4
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/90c5c0b4
Branch: refs/heads/master
Commit: 90c5c0b413af87dee6fd42d90f9145ebf9d9a173
Parents: 40188e6
Author: Meng Zhu <mz...@mesosphere.io>
Authored: Thu Jun 28 16:35:47 2018 -0700
Committer: Chun-Hung Hsiao <ch...@mesosphere.io>
Committed: Thu Jun 28 16:35:47 2018 -0700
----------------------------------------------------------------------
src/tests/default_executor_tests.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/90c5c0b4/src/tests/default_executor_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/default_executor_tests.cpp b/src/tests/default_executor_tests.cpp
index cd7e263..f23cb07 100644
--- a/src/tests/default_executor_tests.cpp
+++ b/src/tests/default_executor_tests.cpp
@@ -1619,7 +1619,8 @@ TEST_P(DefaultExecutorTest, SigkillExecutor)
Future<v1::scheduler::Event::Offers> offers;
EXPECT_CALL(*scheduler, offers(_, _))
- .WillOnce(FutureArg<1>(&offers));
+ .WillOnce(FutureArg<1>(&offers))
+ .WillRepeatedly(Return()); // Ignore further offers.
EXPECT_CALL(*scheduler, heartbeat(_))
.WillRepeatedly(Return()); // Ignore heartbeats.