You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/23 12:59:12 UTC

[GitHub] [calcite-avatica] danny0405 commented on issue #89: [CALCITE-2945] Use Boolean#equals in Boolean object compare

danny0405 commented on issue #89: [CALCITE-2945] Use Boolean#equals in Boolean object compare
URL: https://github.com/apache/calcite-avatica/pull/89#issuecomment-475867778
 
 
   @leesf It looks good, it would be better if you can supply a test case for the bad case when we use `==` as comparator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services