You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "songxiaosheng (via GitHub)" <gi...@apache.org> on 2023/05/22 12:42:40 UTC

[GitHub] [dubbo] songxiaosheng commented on a diff in pull request #12364: Metrics add sliding time window statistics

songxiaosheng commented on code in PR #12364:
URL: https://github.com/apache/dubbo/pull/12364#discussion_r1200463240


##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/key/MetricsKey.java:
##########
@@ -57,7 +57,9 @@ public enum MetricsKey {
     METRIC_RT_P95("dubbo.%s.rt.milliseconds.p95", "Response Time P95"),
     METRIC_RT_P90("dubbo.%s.rt.milliseconds.p90", "Response Time P90"),
     METRIC_RT_P50("dubbo.%s.rt.milliseconds.p50", "Response Time P50"),
-
+    METRIC_RT_INTERNAL_MIN("dubbo.%s.rt.interval.ms.min", "Response min Time Window"),
+    METRIC_RT_INTERNAL_MAX("dubbo.%s.rt.interval.ms.max", "Response max Time Window"),

Review Comment:
   这个命名统一用聚合会不会好看点interval换成聚合



##########
dubbo-dependencies-bom/pom.xml:
##########
@@ -190,7 +190,7 @@
         <portlet_version>2.0</portlet_version>
         <maven_flatten_version>1.5.0</maven_flatten_version>
         <commons_compress_version>1.23.0</commons_compress_version>
-        <revision>3.2.2-SNAPSHOT</revision>
+        <revision>3.2.2</revision>

Review Comment:
   版本号是不是写错啦



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org