You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 23:30:23 UTC
[GitHub] [airflow] SamWheating opened a new pull request #13554: Fix typo under scheduler performance tips
SamWheating opened a new pull request #13554:
URL: https://github.com/apache/airflow/pull/13554
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
I don't think it makes sense to have `{num_processors}+1` parsing processes makes sense, as the processes won't all be able to execute in parallel.
I believe that this is supposed to say `{num_processors}-1`, which would also agree with [this blog post from Astronomer](https://airflow.apache.org/docs/apache-airflow/stable/faq.html#how-to-reduce-airflow-dag-scheduling-latency-in-production)
Discussed with @mik-laj on slack and they were in agreement.
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13554: Fix typo under scheduler performance tips
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13554:
URL: https://github.com/apache/airflow/pull/13554#issuecomment-776881173
https://github.com/apache/airflow/pull/13969 superseded this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #13554: Fix typo under scheduler performance tips
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #13554:
URL: https://github.com/apache/airflow/pull/13554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13554: Fix typo under scheduler performance tips
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13554:
URL: https://github.com/apache/airflow/pull/13554#issuecomment-756461527
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org