You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/24 19:18:59 UTC

[GitHub] [airflow] gunplun opened a new issue #16640: Load Entrypoint Plugins Before Directory Plugins

gunplun opened a new issue #16640:
URL: https://github.com/apache/airflow/issues/16640


   https://github.com/apache/airflow/blob/ffb1fcacff21c31d7cacfbd843a84208fca38d1e/airflow/plugins_manager.py#L291-L292
   Currently, entrypoint plugins are loaded after plugins directory plugins. If there's not a specific reason for this ordering, I think these should be reversed.
   
   For example, if I have a custom operator `MyOperator` that I want to derive from another developer's custom operator `TheirOperator`, and that operator is part of a package that uses the Airflow plugins entrypoint, I would probably have a `my_operator.py` file that looks like this:
   ```python3
   from airflow.operators.their_plugin import TheirOperator
   
   class MyOperator(TheirOperator):
       ...
       ...
   ```
   As it stands, since `MyOperator` is loaded first, this will fail with `ModuleNotFoundError` on `their_package.plugins`, making it needlessly difficult to derive operators from other packages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #16640: Load Entrypoint Plugins Before Directory Plugins

Posted by GitBox <gi...@apache.org>.

uranusjr commented on issue #16640:
URL: https://github.com/apache/airflow/issues/16640#issuecomment-868203297


   You can close this issue if you feel #16641 covers the topic better—or close #16641 otherwise, just keep one open, either way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] gunplun commented on issue #16640: Load Entrypoint Plugins Before Directory Plugins

Posted by GitBox <gi...@apache.org>.

gunplun commented on issue #16640:
URL: https://github.com/apache/airflow/issues/16640#issuecomment-868537199


   Closed because duplicated by #16641 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16640: Load Entrypoint Plugins Before Directory Plugins

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on issue #16640:
URL: https://github.com/apache/airflow/issues/16640#issuecomment-867890731


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] gunplun closed issue #16640: Load Entrypoint Plugins Before Directory Plugins

Posted by GitBox <gi...@apache.org>.

gunplun closed issue #16640:
URL: https://github.com/apache/airflow/issues/16640


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org