[GitHub] [airflow] OmerJog commented on issue #5676: [AIRFLOW-5062] Add support for getting/setting ACL in S3Hook

[GitBox <gi...@apache.org>]

OmerJog commented on issue #5676: [AIRFLOW-5062] Add support for getting/setting ACL in S3Hook
URL: https://github.com/apache/airflow/pull/5676#issuecomment-537793085
 
 
   @LesterKim  Can you please fix the error?
   
   ```
   ======================================================================
   48) ERROR: test_load_file (tests.hooks.test_s3_hook.TestS3Hook)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       /usr/local/lib/python3.6/site-packages/moto/core/models.py line 71 in wrapper
         result = func(*args, **kwargs)
       tests/hooks/test_s3_hook.py line 267 in test_load_file
         hook.load_file(temp_file, "my_key", "mybucket")
       airflow/hooks/S3_hook.py line 56 in wrapper
         return func(*args, **kwargs)
       airflow/hooks/S3_hook.py line 432 in load_file
         client.upload_file(filename, bucket_name, key, ExtraArgs=extra_args)
       /usr/local/lib/python3.6/site-packages/boto3/s3/inject.py line 131 in upload_file
         extra_args=ExtraArgs, callback=Callback)
       /usr/local/lib/python3.6/site-packages/boto3/s3/transfer.py line 273 in upload_file
         raise ValueError('Filename must be a string')
      ValueError: Filename must be a string
      -------------------- >> begin captured logging << --------------------
      airflow.hooks.S3_hook.S3Hook: INFO: Not Found
      --------------------- >> end captured logging << ---------------------
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services