You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/02/12 05:24:36 UTC
[kudu-CR](branch-1.9.x) [client] Fix GetUnscaledDecimal backward compatiblity
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12454
Change subject: [client] Fix GetUnscaledDecimal backward compatiblity
......................................................................
[client] Fix GetUnscaledDecimal backward compatiblity
We added the const version of GetUnscaledDecimal to
the KuduPartialRow. However, that change was not
backward compatible. This patch adds back the
non-const version of the function and tests to
ensure calling both is successful.
Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9
---
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
3 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12454/1
--
To view, visit http://gerrit.cloudera.org:8080/12454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9
Gerrit-Change-Number: 12454
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.9.x) [client] Fix GetUnscaledDecimal backward compatiblity
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12454 )
Change subject: [client] Fix GetUnscaledDecimal backward compatiblity
......................................................................
Patch Set 1: Code-Review+1
LGTM, but will wait on further feedback on the 'master' PS.
--
To view, visit http://gerrit.cloudera.org:8080/12454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9
Gerrit-Change-Number: 12454
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Feb 2019 05:42:27 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.9.x) [client] Fix GetUnscaledDecimal backward compatiblity
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12454 )
Change subject: [client] Fix GetUnscaledDecimal backward compatiblity
......................................................................
[client] Fix GetUnscaledDecimal backward compatiblity
We added the const version of GetUnscaledDecimal to
the KuduPartialRow. However, that change was not
backward compatible. This patch adds back the
non-const version of the function and tests to
ensure calling both is successful.
Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9
Reviewed-on: http://gerrit.cloudera.org:8080/12454
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
3 files changed, 26 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9
Gerrit-Change-Number: 12454
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.9.x) [client] Fix GetUnscaledDecimal backward compatiblity
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12454 )
Change subject: [client] Fix GetUnscaledDecimal backward compatiblity
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9
Gerrit-Change-Number: 12454
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Feb 2019 22:33:00 +0000
Gerrit-HasComments: No