You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/10 03:17:38 UTC

[GitHub] [spark] brandonJY opened a new pull request #31108: [SPARK-34058] [web ui] Add button to show/hide all stage details

brandonJY opened a new pull request #31108:
URL: https://github.com/apache/spark/pull/31108


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   Currently there is no way to expand all stages details all in once. It is hard if you want to navigate to search for specific stages details.
   
   Proposed to add a UI elements to collapse/expand all stages detail in stages tab. 
   ![image](https://user-images.githubusercontent.com/20021316/104113468-03f9b280-5335-11eb-8c96-7e8a00d2f668.png)
   
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   Currently there is no way to expand all stages details all in once. It is hard if you want to navigate to search for specific stages details.
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   There is no button to cexpand/collapse all stages detail all in once
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   manual tested
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-757406857


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] brandonJY commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
brandonJY commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-761949630


   > @brandonJY could you further explain why we need to show all the details? Normally the details are stack traces.
   
   Hey @gengliangwang , sometimes we would want to quick identify a stage, and the code line number is not that helpful. Instead, we would have to go through all the stage detail (a.k.a stack traces) to quickly identify the stage we are looking for. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-758692798


   @brandonJY could you further explain why we need to show all the details? Normally the details are stack traces.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] brandonJY commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
brandonJY commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-758528257


   > Hi @brandonJY , I have three comments.
   > 
   > 1. I tried this change but it doesn't work on my environment (Pop!_OS, an Ubuntu variant, and Firefox). When I click the button you added, I get the following error on the browser's console.
   >    ![errorn-on-click](https://user-images.githubusercontent.com/4736016/104262487-0beb5b00-54cb-11eb-8033-e32db90b2381.png)
   > 2. At first, I couldn't notice where is the button. Users might not notice it's a button.
   > 3. Could you add the screenshots for before/after press the button.
   
   @sarutak  thanks for the reviewing. I have updated the code to make it more visiable with error fixing you mentioned. 
   Before pressing button screenshot
   ![image](https://user-images.githubusercontent.com/20021316/104295778-d7dc5e00-54fb-11eb-8b7d-cb7574534761.png)
   
   
   After pressing button screenshot
   ![image](https://user-images.githubusercontent.com/20021316/104295722-c7c47e80-54fb-11eb-8e95-ac5132251517.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-757406857


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-758358923


   Hi @brandonJY , I have three comments.
   
   1.  I tried this change but it doesn't work on my environment (Pop!_OS, an Ubuntu variant, and Firefox). When I click the button you added, I get the following error on the browser's console.
   ![errorn-on-click](https://user-images.githubusercontent.com/4736016/104262487-0beb5b00-54cb-11eb-8033-e32db90b2381.png)
   
   2. At first, I couldn't notice where is the button. Users might not notice it's a button.
   
   3. Could you add the screenshots for before/after press the button.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] brandonJY closed pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
brandonJY closed pull request #31108:
URL: https://github.com/apache/spark/pull/31108


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-757413056


   cc @sarutak and @gengliangwang FYI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] brandonJY commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

Posted by GitBox <gi...@apache.org>.
brandonJY commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-762554194


   ok. thanks for reviewing. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org