[jira] [Commented] (KYLIN-1488) When modifying a model, Save after deleting a lookup table. The internal error will pop up.

["Zhixiong Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403579#comment-15403579 ] 

Zhixiong Chen commented on KYLIN-1488:
--------------------------------------

As if there is an error in your patch :
if (model.cubes.length == 0) {
      $location.path("/models/edit/"+model.name);
    }else{
      for(var i = 0; i < model.cubes.length; i++){
        cubename[i] = model.cubes[i].name;
      }
      SweetAlert.swal('sorry','this is model still be used by '+ cubename.join(','));
    }
,
even if disable a cube ,however the model.cubes still include this cube,so it will pop up "sorry,this is model..." 

> When modifying a model, Save after deleting a lookup table. The internal error will pop up.
> -------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-1488
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1488
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>            Reporter: Zhong Yanghong
>            Assignee: Zhong,Jason
>         Attachments: modelEditFuc-modify.patch
>
>
> In case of modifying a model which is already used by some cubes, users can delete the lookup table and do the "Save" operation. However, after it's done, the internal error will pop up.
> In normal case, if the model is used by some cubes, we cannot modify the model without disable or drop those cubes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)