You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/20 09:58:19 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #11041: [Bug] fix bug for function `unix_timestamp`
Gabriel39 opened a new pull request, #11041:
URL: https://github.com/apache/doris/pull/11041
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11041: [Bug] fix bug for function `unix_timestamp`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11041:
URL: https://github.com/apache/doris/pull/11041#issuecomment-1190161809
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11041: [Bug] fix bug for function `unix_timestamp`
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11041:
URL: https://github.com/apache/doris/pull/11041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11041: [Bug] fix bug for function `unix_timestamp`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11041:
URL: https://github.com/apache/doris/pull/11041#issuecomment-1190131082
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #11041: [Bug] fix bug for function `unix_timestamp`
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #11041:
URL: https://github.com/apache/doris/pull/11041#discussion_r925462542
##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -206,7 +206,11 @@ struct UnixTimeStampImpl {
const ColumnNumbers& arguments, size_t result,
size_t input_rows_count) {
auto col_result = ColumnVector<Int32>::create();
- col_result->insert(context->impl()->state()->timestamp_ms() / 1000);
+ col_result->resize(input_rows_count);
+ auto& col_result_data = col_result->get_data();
+ for (int i = 0; i < input_rows_count; i++) {
+ col_result_data[i] = context->impl()->state()->timestamp_ms() / 1000;
Review Comment:
Maybe we can calculate it once only on out of loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11041: [Bug] fix bug for function `unix_timestamp`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11041:
URL: https://github.com/apache/doris/pull/11041#issuecomment-1190131118
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org