You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/18 10:21:22 UTC

[GitHub] [airflow] Marloxo opened a new issue #9372: Extend Default Sensitive Variable Fields

Marloxo opened a new issue #9372:
URL: https://github.com/apache/airflow/issues/9372


   
   **Description**
   
   Sensitive variable fields list [here](https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L42) could be extended to be more flexible to include more options.
   
   **Use case / motivation**
   
   It would be better and more extendable if we can use:
   - `token` instead of `access_token`
   - `key` instead of `api_key` and `apikey `
   
   ```PYTHON
   DEFAULT_SENSITIVE_VARIABLE_FIELDS = (
       'password',
       'secret',
       'passwd',
       'authorization',
       'api_key',
       'apikey',
       'access_token',
   )
   ```
   that would give users more freedom in naming their variables
   in my case we have some variables named:
   ex:
   - `TRELLO_KEY`
   - `TRELLO_TOKEN`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #9372: Extend Default Sensitive Variable Fields

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9372:
URL: https://github.com/apache/airflow/issues/9372#issuecomment-645937700


   It will not be difficult to add support for additional labels from the configuration. Would you like to contribute?
   Before you contribute, you should read
   https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9372: Extend Default Sensitive Variable Fields

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #9372:
URL: https://github.com/apache/airflow/issues/9372#issuecomment-645927175


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Marloxo commented on issue #9372: Extend Default Sensitive Variable Fields

Posted by GitBox <gi...@apache.org>.
Marloxo commented on issue #9372:
URL: https://github.com/apache/airflow/issues/9372#issuecomment-646998563


   Closing this issue since it's already fixed with this PR https://github.com/apache/airflow/pull/9397


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Marloxo closed issue #9372: Extend Default Sensitive Variable Fields

Posted by GitBox <gi...@apache.org>.
Marloxo closed issue #9372:
URL: https://github.com/apache/airflow/issues/9372


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Marloxo commented on issue #9372: Extend Default Sensitive Variable Fields

Posted by GitBox <gi...@apache.org>.
Marloxo commented on issue #9372:
URL: https://github.com/apache/airflow/issues/9372#issuecomment-645950567


   yeah sure, I will send a PR in awhile 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org