You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/05/20 11:10:58 UTC

[Bug 57939] New: Classloader leak in org.apache.naming.ContextBindings

https://bz.apache.org/bugzilla/show_bug.cgi?id=57939

            Bug ID: 57939
           Summary: Classloader leak in org.apache.naming.ContextBindings
           Product: Tomcat 8
           Version: 8.0.1
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: nikita@plumbr.eu

This is kind of a follow up on
https://bz.apache.org/bugzilla/show_bug.cgi?id=56275.

We get reports from some of our clients using Tomcat 8 (specific version is
unknown) regarding class loader leak via "clBindings" field of
"org.apache.naming.ContextBindings" where some
"org.apache.catalina.loader.WebappClassLoader" are used as keys in that map and
are not cleaned after application's undeploy. It seems that similar bug was
fixed in Tomcat 6 and 7, but almost the same bug was introduced in Tomcat 8.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57939] Classloader leak in org.apache.naming.ContextBindings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57939

Rainer Jung <ra...@kippdata.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #3 from Rainer Jung <ra...@kippdata.de> ---
The fix had to be reverted. Another fix is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57939] Classloader leak in org.apache.naming.ContextBindings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57939

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|REOPENED                    |RESOLVED

--- Comment #4 from Mark Thomas <ma...@apache.org> ---
The original fix (log a lifecycle listener exception and continue) didn't work
since lifecycle exceptions are expected to be fatal.

I've taken a longer look at the code and an exception in a lifcycle listener is
still the only way I can see this happening. That should result in at least one
log entry with a stack trace and the web application ending up in the failed
state. Under these conditions, a memory leak isn't a surprise and it is the
root cause (of the failed lifecycle listener) that needs to be addressed.

For now I am reslving this as invalid but please feel free to re-open this
issue if any of the following are the case:
- no stack trace is logged (with default logging levels)
- the web application is not marked as failed
- the error is recoverable but the memory leak remains

For any of these please provide the exact steps to reproduce the error form a
clean install of the latest stable Tomcat 8 release. If a web applciation is
required to reproduce it, please keep the web application as simple as
possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57939] Classloader leak in org.apache.naming.ContextBindings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57939

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
This is a symptom of a different problem. It can happen if an uncaught
exception is thrown by an earlier LifecycleListener. You'll probably want to
speak to your clients to find out what went wrong that triggered the earlier
failure.

I'll look add catching and logging such errors to stop them propagating but
generally these sorts of errors are indications that something is broken
somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57939] Classloader leak in org.apache.naming.ContextBindings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57939

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Exceptions will be caught and logged from 8.0.24 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org