You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/03/08 11:24:56 UTC
[GitHub] [guacamole-client] from97 opened a new pull request #599: PROTOCOL_SSH 부분 번역 완료
from97 opened a new pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599
번역 완료했습니다.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] from97 commented on pull request #599: PROTOCOL_SSH 부분 번역 완료
Posted by GitBox <gi...@apache.org>.
from97 commented on pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599#issuecomment-796459245
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] OctopusET commented on pull request #599: PROTOCOL_SSH 부분 번역 완료
Posted by GitBox <gi...@apache.org>.
OctopusET commented on pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599#issuecomment-821785072
Sorry for late response. Translation is done, but test part is left. It might be done by this weekend. I will open another PR soon. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] OctopusET commented on pull request #599: PROTOCOL_SSH 부분 번역 완료
Posted by GitBox <gi...@apache.org>.
OctopusET commented on pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599#issuecomment-793307117
Sorry for wrong PR. It was mistake by my club member and it's my fault.
I didn't explain to my member how to PR properly.
I posted issue on JIRA before GUACAMOLE-1291. If it's done, I will PR here. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #599: PROTOCOL_SSH 부분 번역 완료
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599#issuecomment-797572483
No worries @from97 - I see you closed this pull request, hopefully you'll open another one, soon to add this translation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] from97 closed pull request #599: PROTOCOL_SSH 부분 번역 완료
Posted by GitBox <gi...@apache.org>.
from97 closed pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #599: PROTOCOL_SSH 부분 번역 완료
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599#issuecomment-792714533
@from97
Thank you very much for contributing this to the project - we're always happy to have help in the translation area!
A few things that need to be adjusted, here, before moving forward:
* All pull requests need a matching Issue created in JIRA to track the improvement/bug.
* Once the JIRA issue is created, both the pull request and all commits need to be tagged with the JIRA issue (GUACAMOLE-XXXX:) - see other open pull requests for examples of this.
* You have a lot of commits in this pull request, and they can probably be squashed into a smaller number of commits, with meaningful messages.
* While you did translate the main webapp file, each of the authentication extensions has its own translation file, so it might be worth looking at those and adding those translations while you're at it, if you are so inclined.
Thanks, again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] from97 commented on pull request #599: PROTOCOL_SSH 부분 번역 완료
Posted by GitBox <gi...@apache.org>.
from97 commented on pull request #599:
URL: https://github.com/apache/guacamole-client/pull/599#issuecomment-793348686
My mistake.. I was confused because it was my first PR ever.😂 Thank you @necouchman for your kind comment though, and thanks to @OctopusET also. I'll PR properly next time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org