You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "stuxuhai (via GitHub)" <gi...@apache.org> on 2025/12/19 07:45:14 UTC
[PR] Spark: Fix typo in private method name in RewriteViewCommands [iceberg]
stuxuhai opened a new pull request, #14889:
URL: https://github.com/apache/iceberg/pull/14889
This PR fixes a typo in a private method name in RewriteViewCommands.
The method verifyTemporaryObjectsDontExist has been renamed to verifyTemporaryObjectsDoNotExist. The change is cosmetic only and does not affect behavior or public APIs.
This PR addresses a small typo found during Spark related code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix typo in private method name in RewriteViewCommands [iceberg]
Posted by "stuxuhai (via GitHub)" <gi...@apache.org>.
stuxuhai commented on PR #14889:
URL: https://github.com/apache/iceberg/pull/14889#issuecomment-3674299137
@majian1998 Thanks for the clarification. That makes sense. If this is a commonly used convention across Spark and related projects, I’m fine with leaving it as is. Please feel free to close the PR if you think it’s unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix typo in private method name in RewriteViewCommands [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #14889:
URL: https://github.com/apache/iceberg/pull/14889#discussion_r2635019349
##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala:
##########
@@ -61,7 +61,7 @@ case class RewriteViewCommands(spark: SparkSession) extends Rule[LogicalPlan] wi
allowExisting,
replace) =>
val q = CTESubstitution.apply(query)
- verifyTemporaryObjectsDontExist(resolved, q)
+ verifyTemporaryObjectsDoNotExist(resolved, q)
Review Comment:
yep that isn't a typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix typo in private method name in RewriteViewCommands [iceberg]
Posted by "majian1998 (via GitHub)" <gi...@apache.org>.
majian1998 commented on PR #14889:
URL: https://github.com/apache/iceberg/pull/14889#issuecomment-3674282676
In fact, I don’t think this is a typo—other repos like Spark and Delta Lake also use the shorthand “dont” instead of “do not.” :see_no_evil:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spark: Fix typo in private method name in RewriteViewCommands [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed pull request #14889: Spark: Fix typo in private method name in RewriteViewCommands
URL: https://github.com/apache/iceberg/pull/14889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org