You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "uhayat (via GitHub)" <gi...@apache.org> on 2024/11/07 07:36:01 UTC
[PR] Add support for PG17 [age]
uhayat opened a new pull request, #2130:
URL: https://github.com/apache/age/pull/2130
- A new node type is introduced for JSON support, that is JsonConstructorExpr - wrapper over FuncExpr/Aggref/WindowFunc for SQL/JSON constructors.
- Added additional checks for JsonConstructorExpr expression node for which the walker would crash.
- Removed palloc0fast function call (which is not available in PG17)
With these fixes `make installcheck` regression passed on MacOS 11.x and Ubuntu 20.04 LTS with following summary
```
umarhayat@Umars-MacBook-Pro age % make installcheck
echo "# +++ regress install-check in +++" && /Users/umarhayat/dev/pg_out/pg_17/lib/postgresql/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --bindir='/Users/umarhayat/dev/pg_out/pg_17/bin' --load-extension=age --inputdir=.//regress --outputdir=.//regress --temp-instance=.//regress/instance --port=61958 --encoding=UTF-8 --temp-config .//regress/age_regression.conf --dbname=contrib_regression scan graphid agtype agtype_hash_cmp catalog cypher expr cypher_create cypher_match cypher_unwind cypher_set cypher_remove cypher_delete cypher_with cypher_vle cypher_union cypher_call cypher_merge cypher_subquery age_global_graph age_load index analyze graph_generation name_validation jsonb_operators list_comprehension map_projection drop
# +++ regress install-check in +++
# initializing database system by running initdb
# using temp instance on port 61958 with PID 2824
ok 1 - scan 186 ms
ok 2 - graphid 9 ms
ok 3 - agtype 54 ms
ok 4 - agtype_hash_cmp 7 ms
ok 5 - catalog 43 ms
ok 6 - cypher 25 ms
ok 7 - expr 378 ms
ok 8 - cypher_create 57 ms
ok 9 - cypher_match 269 ms
ok 10 - cypher_unwind 25 ms
ok 11 - cypher_set 60 ms
ok 12 - cypher_remove 36 ms
ok 13 - cypher_delete 212 ms
ok 14 - cypher_with 33 ms
ok 15 - cypher_vle 506 ms
ok 16 - cypher_union 15 ms
ok 17 - cypher_call 19 ms
ok 18 - cypher_merge 165 ms
ok 19 - cypher_subquery 33 ms
ok 20 - age_global_graph 91 ms
ok 21 - age_load 831 ms
ok 22 - index 47 ms
ok 23 - analyze 14 ms
ok 24 - graph_generation 32 ms
ok 25 - name_validation 62 ms
ok 26 - jsonb_operators 45 ms
ok 27 - list_comprehension 33 ms
ok 28 - map_projection 19 ms
ok 29 - drop 119 ms
1..29
# All 29 tests passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for PG17 [age]
Posted by "sorrell (via GitHub)" <gi...@apache.org>.
sorrell commented on PR #2130:
URL: https://github.com/apache/age/pull/2130#issuecomment-2668733161
This is now targeting a base of `PG17_prepare`, looking for feedback from other committers like @jrgemignani and @MuhammadTahaNaveed please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for PG17 [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani merged PR #2130:
URL: https://github.com/apache/age/pull/2130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for PG17 [age]
Posted by "df7cb (via GitHub)" <gi...@apache.org>.
df7cb commented on PR #2130:
URL: https://github.com/apache/age/pull/2130#issuecomment-2577298954
This PR made the AGE packages in Debian and apt.postgresql.org work. Please apply it and don't let the robot apocalypse auto-close it. :smile_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for PG17 [age]
Posted by "seuros (via GitHub)" <gi...@apache.org>.
seuros commented on PR #2130:
URL: https://github.com/apache/age/pull/2130#issuecomment-2595682174
Should we expect this PR to get merged? It's been open since the last Ice AGE! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for PG17 [age]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2130:
URL: https://github.com/apache/age/pull/2130#issuecomment-2574147420
This PR is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for PG17 [age]
Posted by "uhayat (via GitHub)" <gi...@apache.org>.
uhayat commented on PR #2130:
URL: https://github.com/apache/age/pull/2130#issuecomment-2597234874
@seuros after this PR merge some one need to create branch for PG 17 and update the README with supported PG version and would also need a new PR. If nobody is merging this PR I don't expected anyone merging a mere README update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for PG17 [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #2130:
URL: https://github.com/apache/age/pull/2130#issuecomment-2675262708
I merged it as it is required for PG17 to build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org