[GitHub] [spark] mgaido91 commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

[GitBox <gi...@apache.org>]

mgaido91 commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions
URL: https://github.com/apache/spark/pull/20965#issuecomment-518014276
 
 
   my point is that we should discuss what is the community approach on tackling these issues, since there are many places when this can occur.
   
   There was a first proposal by @viirya which was started, but then stopped in favor of a better approach using IR. Now, I don't see any active approach being followed at all. So I think we should discuss that. I am not against this PR, but then the same work may be performed also in other cases (it may cause - though - suboptimal situations if our target will be different). My question is: is that what we want to do?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org